media/audio/audio_input_volume_unittest.cc - Issue 9570014: Move some generic functions to AudioManagerBase to be inherited by platform-specific AudioManager***

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_input_volume_unittest.cc

Issue 9570014: Move some generic functions to AudioManagerBase to be inherited by platform-specific AudioManager*** (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix the memory leak in the alsa unittests Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/audio/android/audio_manager_android.cc ('K') | « media/audio/android/audio_manager_android.cc ('k') | media/audio/audio_manager_base.h » ('j') | media/audio/audio_manager_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/audio_input_volume_unittest.cc

diff --git a/media/audio/audio_input_volume_unittest.cc b/media/audio/audio_input_volume_unittest.cc

index 5a006f08256baa0cbd67b44d0b28a874917f1c90..ea0f175ff1ff8a0406655c5bc991d646b4f3408e 100644

--- a/media/audio/audio_input_volume_unittest.cc

+++ b/media/audio/audio_input_volume_unittest.cc

@@ -95,7 +95,8 @@ TEST_F(AudioInputVolumeTest, InputVolumeTest) {

AudioDeviceNames device_names;

audio_manager_->GetAudioInputDeviceNames(&device_names);

- DCHECK(!device_names.empty());

+ if (device_names.empty())

+ return;

tommi (sloooow) - chröme 2012/03/05 14:28:28 LOG(WARNING)

no longer working on chromium 2012/03/06 15:27:07 Done.

for (AudioDeviceNames::const_iterator it = device_names.begin();

it != device_names.end();

« media/audio/android/audio_manager_android.cc ('K') | « media/audio/android/audio_manager_android.cc ('k') | media/audio/audio_manager_base.h » ('j') | media/audio/audio_manager_base.cc » ('J')