Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: media/audio/android/audio_manager_android.cc

Issue 9570014: Move some generic functions to AudioManagerBase to be inherited by platform-specific AudioManager*** (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix the memory leak in the alsa unittests Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/android/audio_manager_android.cc
diff --git a/media/audio/android/audio_manager_android.cc b/media/audio/android/audio_manager_android.cc
index 0170675a43442425ab0e0d83597ec848707282a1..e74b0ffe6247d89f03d46c38c1ee506594b5812b 100644
--- a/media/audio/android/audio_manager_android.cc
+++ b/media/audio/android/audio_manager_android.cc
@@ -8,7 +8,9 @@
#include "media/audio/android/audio_track_output_android.h"
#include "media/audio/audio_manager.h"
#include "media/audio/fake_audio_input_stream.h"
-#include "media/audio/fake_audio_output_stream.h"
+
+// Maximum number of output streams that can be open simultaneously.
+static const int kMaxOutputStreams = 10;
AudioManager* CreateAudioManager() {
return new AudioManagerAndroid();
@@ -28,29 +30,38 @@ bool AudioManagerAndroid::HasAudioInputDevices() {
return false;
}
-AudioOutputStream* AudioManagerAndroid::MakeAudioOutputStream(
- const AudioParameters& params) {
- if (!params.IsValid())
- return NULL;
+void AudioManagerAndroid::MuteAll() {
+ NOTIMPLEMENTED();
+}
- if (params.format == AudioParameters::AUDIO_MOCK)
- return FakeAudioOutputStream::MakeFakeStream(params);
- if (params.format == AudioParameters::AUDIO_PCM_LINEAR ||
- params.format == AudioParameters::AUDIO_PCM_LOW_LATENCY)
- return AudioTrackOutputStream::MakeStream(params);
+void AudioManagerAndroid::UnMuteAll() {
+ NOTIMPLEMENTED();
+}
- return NULL;
+int AudioManagerAndroid::GetMaxAudioOutputStreamsAllowed() {
+ return kMaxOutputStreams;
}
-AudioInputStream* AudioManagerAndroid::MakeAudioInputStream(
- const AudioParameters& params, const std::string& device_id) {
- return FakeAudioInputStream::MakeFakeStream(params);
+AudioOutputStream* AudioManagerAndroid::MakeAudioLinearOutputStream(
+ const AudioParameters& params) {
+ DCHECK_EQ(AudioParameters::AUDIO_PCM_LINEAR, params.format);
+ return AudioTrackOutputStream::MakeStream(params);
}
-void AudioManagerAndroid::MuteAll() {
- NOTIMPLEMENTED();
+AudioOutputStream* AudioManagerAndroid::MakeAudioLowLatencyOutputStream(
+ const AudioParameters& params) {
+ DCHECK_EQ(AudioParameters::AUDIO_PCM_LOW_LATENCY, params.format);
+ return AudioTrackOutputStream::MakeStream(params);;
tommi (sloooow) - chröme 2012/03/05 14:28:28 fix indent and remove extra semicolon
no longer working on chromium 2012/03/06 15:27:07 Done.
}
-void AudioManagerAndroid::UnMuteAll() {
- NOTIMPLEMENTED();
+AudioInputStream* AudioManagerAndroid::MakeAudioLinearInputStream(
+ const AudioParameters& params, const std::string& device_id) {
+ DCHECK_EQ(AudioParameters::AUDIO_PCM_LINEAR, params.format);
+ return FakeAudioInputStream::MakeFakeStream(params);
+}
+
+AudioInputStream* AudioManagerAndroid::MakeAudioLowLatencyInputStream(
+ const AudioParameters& params, const std::string& device_id) {
+ DCHECK_EQ(AudioParameters::AUDIO_PCM_LOW_LATENCY, params.format);
+ return FakeAudioInputStream::MakeFakeStream(params);
}

Powered by Google App Engine
This is Rietveld 408576698