Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: media/audio/android/audio_manager_android.h

Issue 9570014: Move some generic functions to AudioManagerBase to be inherited by platform-specific AudioManager*** (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix the memory leak in the alsa unittests Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/android/audio_manager_android.h
diff --git a/media/audio/android/audio_manager_android.h b/media/audio/android/audio_manager_android.h
index ab43a60dac109f37b02d2dc752d3b50bdf1b31ce..cab9f2ce7ecb54aa542d771ecb022e48eee8c52a 100644
--- a/media/audio/android/audio_manager_android.h
+++ b/media/audio/android/audio_manager_android.h
@@ -15,13 +15,20 @@ class AudioManagerAndroid : public AudioManagerBase {
// Implementation of AudioManager.
virtual bool HasAudioOutputDevices() OVERRIDE;
virtual bool HasAudioInputDevices() OVERRIDE;
- virtual AudioOutputStream* MakeAudioOutputStream(
- const AudioParameters& params) OVERRIDE;
- virtual AudioInputStream* MakeAudioInputStream(
- const AudioParameters& params, const std::string& device_id) OVERRIDE;
virtual void MuteAll() OVERRIDE;
virtual void UnMuteAll() OVERRIDE;
+ // Implementation of AudioManagerBase.
+ virtual int GetMaxAudioOutputStreamsAllowed() OVERRIDE;
tommi (sloooow) - chröme 2012/03/05 14:28:28 return size_t?
no longer working on chromium 2012/03/06 15:27:07 As we discussed, hope it is fine to use int.
+ virtual AudioOutputStream* MakeAudioLinearOutputStream(
tommi (sloooow) - chröme 2012/03/05 14:28:28 I think the word "Audio" isn't necessary in these
no longer working on chromium 2012/03/06 15:27:28 Done.
+ const AudioParameters& params) OVERRIDE;
+ virtual AudioOutputStream* MakeAudioLowLatencyOutputStream(
+ const AudioParameters& params) OVERRIDE;
+ virtual AudioInputStream* MakeAudioLinearInputStream(
+ const AudioParameters& params, const std::string& device_id) OVERRIDE;
+ virtual AudioInputStream* MakeAudioLowLatencyInputStream(
+ const AudioParameters& params, const std::string& device_id) OVERRIDE;
+
protected:
virtual ~AudioManagerAndroid();
« no previous file with comments | « no previous file | media/audio/android/audio_manager_android.cc » ('j') | media/audio/android/audio_manager_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698