Support for a dart2js `dartDeferredLoader` hook.

Support for a dart2js `dartDeferredLoader` hook.

Also move deferred loading special casing of d8 and jsshell to
preambles.

BUG=
R=floitsch@google.com, lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44163

[sigurdm, 2015-02-25 15:34:59]

sigurdm@google.com changed reviewers:
+ floitsch@google.com

[sigurdm, 2015-02-25 15:34:59]

There is a problem with a csp-mode test failing. I think it should not have been
passing in the first place. Will investigate more tomorrow.

[floitsch, 2015-02-25 15:59:59]

floitsch@google.com changed reviewers:
+ lrn@google.com

[floitsch, 2015-02-25 16:00:00]

LGTM, but wait for Lasse.

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/preambles/d8.js (right):

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/preambles/d8.js:282: self.self = self;
Create a "section" (with a comment).

Keep 'self.self = self' last (or move it to the very top).

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/preambles/jsshell.js (right):

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/preambles/jsshell.js:22: print("Loading
"+uri);
Remove?

[Lasse Reichstein Nielsen, 2015-02-26 08:44:09]

lgtm

https://codereview.chromium.org/956953002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart (right):

https://codereview.chromium.org/956953002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart:63: //    is
loaded. It should load and eval the javascript on uri, and call
javascript on uri -> javascript of `uri`

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/preambles/d8.js (right):

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/preambles/d8.js:286: (new
Function(load(uri)))();
What is the "new Function" supposed to do?
I think "load" will load *and* execute the script in the top-level scope, and
then return undefined.
You are basically loading it, and then doing "new Function(undefined)()".

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/preambles/jsshell.js (right):

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/preambles/jsshell.js:24: (new
Function(load(uri)))();
Remove Function here too.

[sigurdm, 2015-02-26 13:19:05]

https://codereview.chromium.org/956953002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart (right):

https://codereview.chromium.org/956953002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/declarations.dart:63: //    is
loaded. It should load and eval the javascript on uri, and call
On 2015/02/26 08:44:09, Lasse Reichstein Nielsen wrote:
> javascript on uri -> javascript of `uri`

Done.

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/preambles/d8.js (right):

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/preambles/d8.js:282: self.self = self;
On 2015/02/25 16:00:00, floitsch wrote:
> Create a "section" (with a comment).
> 
> Keep 'self.self = self' last (or move it to the very top).

Done.

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/preambles/d8.js:286: (new
Function(load(uri)))();
On 2015/02/26 08:44:09, Lasse Reichstein Nielsen wrote:
> What is the "new Function" supposed to do?
> I think "load" will load *and* execute the script in the top-level scope, and
> then return undefined.
> You are basically loading it, and then doing "new Function(undefined)()".

Yes, I realized that this morning also.

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/preambles/jsshell.js (right):

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/preambles/jsshell.js:22: print("Loading
"+uri);
On 2015/02/25 16:00:00, floitsch wrote:
> Remove?

Done.

https://codereview.chromium.org/956953002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/preambles/jsshell.js:24: (new
Function(load(uri)))();
On 2015/02/26 08:44:09, Lasse Reichstein Nielsen wrote:
> Remove Function here too.

Done.

[sigurdm, 2015-03-03 10:12:21]

Committed patchset #3 (id:40001) manually as 44163 (presubmit successful).

[sra1, 2015-04-16 17:23:04]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-04-16 17:23:04]

https://chromiumcodereview.appspot.com/956953002/diff/40001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/956953002/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3499: var xhr = JS('dynamic',
'new XMLHttpRequest()');
Don't use dynamic here.
Use '' or 'var'.

'dynamic' means all possible types from dart:html.
'var', which is not a type, means 'trust me this is nothing interesting'.

'dynamic' can cause quite a lot of bloat as recently seen by customers.

[sigurdm, 2015-04-17 08:37:37]

https://chromiumcodereview.appspot.com/956953002/diff/40001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/956953002/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3499: var xhr = JS('dynamic',
'new XMLHttpRequest()');
On 2015/04/16 17:23:04, sra1 wrote:
> Don't use dynamic here.
> Use '' or 'var'.
> 
> 'dynamic' means all possible types from dart:html.
> 'var', which is not a type, means 'trust me this is nothing interesting'.
> 
> 'dynamic' can cause quite a lot of bloat as recently seen by customers.

Acknowledged. It seems you already made the change.