Issue 9564034: Separate out the Windows bookmark handling code out of the core drag & drop target class. This matc…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9564034: Separate out the Windows bookmark handling code out of the core drag & drop target class. This matc… (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
dcheng

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Separate out the Windows bookmark handling code out of the core drag & drop target class. This matches what we do on mac/gtk and is in prepartion for moving the core class to content (like what we did for mac/gtk). BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124553

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+170 lines, -60 lines)			Patch
A	chrome/browser/tab_contents/web_drag_bookmark_handler_win.h	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	chrome/browser/tab_contents/web_drag_bookmark_handler_win.cc	View	1 chunk	+91 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drop_target_win.h	View	4 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drop_target_win.cc	View	7 chunks	+18 lines, -49 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/web_drag_dest_delegate.h	View	4 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages