Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/browser/tab_contents/web_drag_dest_delegate.h

Issue 9564034: Separate out the Windows bookmark handling code out of the core drag & drop target class. This matc… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/web_drag_dest_delegate.h
===================================================================
--- content/browser/tab_contents/web_drag_dest_delegate.h (revision 124430)
+++ content/browser/tab_contents/web_drag_dest_delegate.h (working copy)
@@ -11,8 +11,11 @@
#endif // TOOLKIT_USES_GTK
#include "base/string16.h"
-#include "content/common/content_export.h"
+#if defined(OS_WIN)
+#include "ui/base/dragdrop/drop_target.h"
+#endif
+
class GURL;
namespace content {
@@ -20,7 +23,7 @@
class WebContents;
// An optional delegate that listens for drags of bookmark data.
-class CONTENT_EXPORT WebDragDestDelegate {
+class WebDragDestDelegate {
public:
// Announces that a drag has started. It's valid that a drag starts, along
// with over/enter/leave/drop notifications without receiving any bookmark
@@ -28,9 +31,18 @@
virtual void DragInitialize(WebContents* contents) = 0;
// Notifications of drag progression.
+#if defined(OS_WIN)
+ virtual void OnDragOver(IDataObject* data_object) = 0;
+ virtual void OnDragEnter(IDataObject* data_object) = 0;
+ virtual void OnDrop(IDataObject* data_object) = 0;
+ virtual void OnDragLeave(IDataObject* data_object) = 0;
+#else
virtual void OnDragOver() = 0;
virtual void OnDragEnter() = 0;
virtual void OnDrop() = 0;
+ // This should also clear any state kept about this drag.
+ virtual void OnDragLeave() = 0;
+#endif
#if defined(TOOLKIT_USES_GTK)
// Returns the bookmark atom type. GTK and Views return different values here.
@@ -43,9 +55,6 @@
const string16& title) = 0;
#endif // TOOLKIT_USES_GTK
- // This should also clear any state kept about this drag.
- virtual void OnDragLeave() = 0;
-
virtual ~WebDragDestDelegate() {}
};
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698