Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: chrome/browser/ui/panels/docked_panel_strip.h

Issue 9560002: Cleanup to keep panel from manipulating its panel strip assignment directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: removed unneeded includes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/docked_panel_strip.h
diff --git a/chrome/browser/ui/panels/docked_panel_strip.h b/chrome/browser/ui/panels/docked_panel_strip.h
index 2fb002943a84d77ae1a730dd4bf1c3e73b0a1e1a..56aad97fd05546de2907a06a4e01949f18b8cf5d 100644
--- a/chrome/browser/ui/panels/docked_panel_strip.h
+++ b/chrome/browser/ui/panels/docked_panel_strip.h
@@ -43,7 +43,7 @@ class DockedPanelStrip : public PanelStrip,
// Adds a panel to the strip. The panel may be a newly created panel or one
// that is transitioning from another grouping of panels.
virtual void AddPanel(Panel* panel) OVERRIDE;
- virtual bool RemovePanel(Panel* panel) OVERRIDE;
+ virtual void RemovePanel(Panel* panel) OVERRIDE;
virtual void CloseAll() OVERRIDE;
virtual void ResizePanelWindow(
Panel* panel,
@@ -52,6 +52,7 @@ class DockedPanelStrip : public PanelStrip,
virtual void ActivatePanel(Panel* panel) OVERRIDE;
virtual void MinimizePanel(Panel* panel) OVERRIDE;
virtual void RestorePanel(Panel* panel) OVERRIDE;
+ virtual bool IsPanelMinimized(const Panel* panel) const OVERRIDE;
virtual bool CanShowPanelAsActive(const Panel* panel) const OVERRIDE;
virtual bool CanDragPanel(const Panel* panel) const OVERRIDE;
virtual void StartDraggingPanel(Panel* panel) OVERRIDE;
@@ -91,6 +92,9 @@ class DockedPanelStrip : public PanelStrip,
void OnFullScreenModeChanged(bool is_full_screen);
+ // Returns |true| if panel can fit in the dock strip.
+ bool CanFitPanel(Panel* panel);
jianli 2012/03/02 00:11:41 nit: need to add const modifier.
jennb 2012/03/02 01:26:32 Done.
+
#ifdef UNIT_TEST
int num_temporary_layout_panels() const {
return panels_in_temporary_layout_.size();
@@ -107,6 +111,12 @@ class DockedPanelStrip : public PanelStrip,
// Overridden from PanelMouseWatcherObserver:
virtual void OnMouseMove(const gfx::Point& mouse_position) OVERRIDE;
+ // Make |width| amount of space available in this strip.
+ void EnsureAvailableSpace(int width);
+
+ // Move all panels after |overflow_point|, inclusive, to overflow.
jianli 2012/03/02 00:11:41 Not sure I understand what overflow_point means? P
jennb 2012/03/02 01:26:32 Done.
+ void MovePanelsToOverflow(Panel* overflow_point);
+
// Keep track of the minimized panels to control mouse watching.
void IncrementMinimizedPanels();
void DecrementMinimizedPanels();

Powered by Google App Engine
This is Rietveld 408576698