Cleanup to keep panel from manipulating its panel strip assignment directly.

chrome/browser/ui/panels/docked_panel_strip.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_DOCKED_PANEL_STRIP_H_
 #define CHROME_BROWSER_UI_PANELS_DOCKED_PANEL_STRIP_H_
 #pragma once
 
 #include <list>
 #include <set>
@@ skipping 25 matching lines @@
 
   // Rearranges the positions of the panels in the strip.
   // Handles moving panels to/from overflow area as needed.
   // This is called when the display space has been changed, i.e. working
   // area being changed or a panel being closed.
   virtual void RefreshLayout() OVERRIDE;
 
   // Adds a panel to the strip. The panel may be a newly created panel or one
   // that is transitioning from another grouping of panels.
   virtual void AddPanel(Panel* panel) OVERRIDE;
-  virtual bool RemovePanel(Panel* panel) OVERRIDE;
+  virtual void RemovePanel(Panel* panel) OVERRIDE;
   virtual void CloseAll() OVERRIDE;
   virtual void ResizePanelWindow(
       Panel* panel,
       const gfx::Size& preferred_window_size) OVERRIDE;
   virtual void OnPanelAttentionStateChanged(Panel* panel) OVERRIDE;
   virtual void ActivatePanel(Panel* panel) OVERRIDE;
   virtual void MinimizePanel(Panel* panel) OVERRIDE;
   virtual void RestorePanel(Panel* panel) OVERRIDE;
+  virtual bool IsPanelMinimized(const Panel* panel) const OVERRIDE;
   virtual bool CanShowPanelAsActive(const Panel* panel) const OVERRIDE;
   virtual bool CanDragPanel(const Panel* panel) const OVERRIDE;
   virtual void StartDraggingPanel(Panel* panel) OVERRIDE;
   virtual void DragPanel(Panel* panel, int delta_x, int delta_y) OVERRIDE;
   virtual void EndDraggingPanel(Panel* panel, bool cancelled) OVERRIDE;
 
   // Invoked when a panel's expansion state changes.
   void OnPanelExpansionStateChanged(Panel* panel);
 
   // Returns true if we should bring up the titlebars, given the current mouse
@@ skipping 19 matching lines @@
   int GetMaxPanelWidth() const;
   int GetMaxPanelHeight() const;
   int StartingRightPosition() const;
 
   void OnAutoHidingDesktopBarVisibilityChanged(
       AutoHidingDesktopBar::Alignment alignment,
       AutoHidingDesktopBar::Visibility visibility);
 
   void OnFullScreenModeChanged(bool is_full_screen);
 
+  // Returns |true| if panel can fit in the dock strip.
+  bool CanFitPanel(Panel* panel);

[jianli, 2012/03/02 00:11:41]

nit: need to add const modifier.

[jennb, 2012/03/02 01:26:32]

Done.

+
 #ifdef UNIT_TEST
   int num_temporary_layout_panels() const {
     return panels_in_temporary_layout_.size();
   }
 #endif
 
  private:
   enum TitlebarAction {
     NO_ACTION,
     BRING_UP,
     BRING_DOWN
   };
 
   // Overridden from PanelMouseWatcherObserver:
   virtual void OnMouseMove(const gfx::Point& mouse_position) OVERRIDE;
 
+  // Make |width| amount of space available in this strip.
+  void EnsureAvailableSpace(int width);
+
+  // Move all panels after |overflow_point|, inclusive, to overflow.

[jianli, 2012/03/02 00:11:41]

Not sure I understand what overflow_point means? Probably sth like:
 void MovePanelsToOverflowUntil(Panel* last_panel_to_move_to_overflow)

[jennb, 2012/03/02 01:26:32]

Done.

+  void MovePanelsToOverflow(Panel* overflow_point);
+
   // Keep track of the minimized panels to control mouse watching.
   void IncrementMinimizedPanels();
   void DecrementMinimizedPanels();
 
   // Help functions to drag the given panel.
   void DragLeft(Panel* dragging_panel);
   void DragRight(Panel* dragging_panel);
 
   // Does the real job of bringing up or down the titlebars.
   void DoBringUpOrDownTitlebars(bool bring_up);
@@ skipping 50 matching lines @@
   // Absolute minimum width and height for panels, including non-client area.
   // Should only be big enough to accomodate a close button on the reasonably
   // recognisable titlebar.
   static const int kPanelMinWidth;
   static const int kPanelMinHeight;
 
   DISALLOW_COPY_AND_ASSIGN(DockedPanelStrip);
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_DOCKED_PANEL_STRIP_H_