Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: runtime/vm/object.cc

Issue 9549008: Fix Issue 1844: Throw exception instead of crashing if the size of allocated array is too large (or… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 4769)
+++ runtime/vm/object.cc (working copy)
@@ -7893,9 +7893,10 @@
RawArray* Array::New(const Class& cls, intptr_t len, Heap::Space space) {
if ((len < 0) || (len > kMaxArrayElements)) {
- // TODO(iposva): Should we throw an illegal parameter exception?
- UNIMPLEMENTED();
- return null();
+ // TODO(srdjan): Verify that illegal argument is the right thing to throw.
+ GrowableArray<const Object*> args;
+ args.Add(&Smi::Handle(Smi::New(len)));
+ Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
}
Array& result = Array::Handle();
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698