Fix Issue 1844: Throw exception instead of crashing if the size of allocated array is too large (or…

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 7875 matching lines @@
 
 RawArray* Array::New(intptr_t len, Heap::Space space) {
   ObjectStore* object_store = Isolate::Current()->object_store();
   Class& cls = Class::Handle(object_store->array_class());
   return New(cls, len, space);
 }
 
 
 RawArray* Array::New(const Class& cls, intptr_t len, Heap::Space space) {
   if ((len < 0) || (len > kMaxArrayElements)) {
-    // TODO(iposva): Should we throw an illegal parameter exception?
-    UNIMPLEMENTED();
-    return null();
+    // TODO(srdjan): Verify that illegal argument is the right thing to throw.
+    GrowableArray<const Object*> args;
+    args.Add(&Smi::Handle(Smi::New(len)));
+    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
   }
   Array& result = Array::Handle();
   {
     RawObject* raw = Object::Allocate(cls,
                                       Array::InstanceSize(len),
                                       space);
     NoGCScope no_gc;
     result ^= raw;
     result.SetLength(len);
   }
@@ skipping 596 matching lines @@
   result.set_num_args_tested(num_args_tested);
   // Number of array elements in one test entry (num_args_tested + 1)
   intptr_t len = num_args_tested + 1;
   // IC data array must be null terminated (sentinel entry).
   Array& ic_data = Array::Handle(Array::New(len, Heap::kOld));
   result.set_ic_data(ic_data);
   return result.raw();
 }
 
 }  // namespace dart