Issue 9537007: Implement native getters and setters and move supported tests to 'native'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9537007: Implement native getters and setters and move supported tests to 'native'. (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
sra1, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement native getters and setters and move supported tests to 'native'. Committed: https://code.google.com/p/dart/source/detail?r=4743

Patch Set 1 : #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -308 lines)			Patch
M	frog/leg/native_handler.dart	View	4 chunks	+23 lines, -7 lines	2 comments	Download
M	frog/tests/frog/frog.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	frog/tests/frog/src/NativeCheckedArguments1FrogTest.dart	View	1 chunk	+0 lines, -138 lines	0 comments	Download
D	frog/tests/frog/src/NativeCheckedFieldsFrogTest.dart	View	1 chunk	+0 lines, -112 lines	0 comments	Download
D	frog/tests/frog/src/NativePropertyFrogTest.dart	View	1 chunk	+0 lines, -52 lines	0 comments	Download
M	frog/tests/native/native.status	View	1 chunk	+9 lines, -1 line	0 comments	Download
A +	frog/tests/native/src/NativeCheckedArguments1FrogTest.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	frog/tests/native/src/NativeCheckedFieldsFrogTest.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	frog/tests/native/src/NativePropertyFrogTest.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/9537007/diff/1010/frog/leg/native_handler.dart File frog/leg/native_handler.dart (right): https://chromiumcodereview.appspot.com/9537007/diff/1010/frog/leg/native_handler.dart#newcode131 frog/leg/native_handler.dart:131: String dartMethodName; I guess this almost calls for ...

8 years, 9 months ago (2012-02-29 10:16:38 UTC) #2

ngeoffray

8 years, 9 months ago (2012-02-29 10:19:19 UTC) #3

Thanks for the review Kasper.

https://chromiumcodereview.appspot.com/9537007/diff/1010/frog/leg/native_hand...
File frog/leg/native_handler.dart (right):

https://chromiumcodereview.appspot.com/9537007/diff/1010/frog/leg/native_hand...
frog/leg/native_handler.dart:131: String dartMethodName;
On 2012/02/29 10:16:38, kasperl wrote:
> I guess this almost calls for an abstraction with these three fields.

We have the element, but I'm not sure I want to pollute the Element classes with
these native considerations.

Expand Messages | Collapse Messages