webkit/appcache/web_application_cache_host_impl.cc - Issue 9534003: DCHECK sets a variable, instead of comparing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/appcache/web_application_cache_host_impl.cc

Issue 9534003: DCHECK sets a variable, instead of comparing (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/appcache/web_application_cache_host_impl.cc

===================================================================

--- webkit/appcache/web_application_cache_host_impl.cc (revision 123977)

+++ webkit/appcache/web_application_cache_host_impl.cc (working copy)

@@ -226,7 +226,7 @@

return true;

}

- DCHECK(is_new_master_entry_ = NO);

+ DCHECK(is_new_master_entry_ == NO);

michaeln 2012/02/29 20:35:27 yikes!

michaeln 2012/02/29 20:36:25 actually, would be good to use DCHECK_EQ(NO, is_ne

Myles C. Maxfield 2012/02/29 22:11:40 Done.

// 6.9.6 The application cache selection algorithm

// Check for 'foreign' entries.

« no previous file with comments | « no previous file | no next file » | no next file with comments »