DCHECK sets a variable, instead of comparing

webkit/appcache/web_application_cache_host_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/appcache/web_application_cache_host_impl.h"
 
 #include "base/compiler_specific.h"
 #include "base/id_map.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
@@ skipping 208 matching lines @@
     } else {
       status_ = UNCACHED;
       is_new_master_entry_ = NO;
       manifest_gurl = GURL();
     }
     backend_->SelectCache(host_id_, document_url_,
                           kNoCacheId, manifest_gurl);
     return true;
   }
 
-  DCHECK(is_new_master_entry_ = NO);
+  DCHECK(is_new_master_entry_ == NO);

[michaeln, 2012/02/29 20:35:27]

yikes!

[michaeln, 2012/02/29 20:36:25]

actually, would be good to use DCHECK_EQ(NO, is_new) here.

[Myles C. Maxfield, 2012/02/29 22:11:40]

Done.

 
   // 6.9.6 The application cache selection algorithm
   // Check for 'foreign' entries.
   GURL document_manifest_gurl(document_response_.appCacheManifestURL());
   if (document_manifest_gurl != manifest_gurl) {
     backend_->MarkAsForeignEntry(host_id_, document_url_,
                                  document_response_.appCacheID());
     status_ = UNCACHED;
     return false;  // the navigation will be restarted
   }
@@ skipping 79 matching lines @@
     web_resources[i].isExplicit = resource_infos[i].is_explicit;
     web_resources[i].isManifest = resource_infos[i].is_manifest;
     web_resources[i].isForeign = resource_infos[i].is_foreign;
     web_resources[i].isFallback = resource_infos[i].is_fallback;
     web_resources[i].url = resource_infos[i].url;
   }
   resources->swap(web_resources);
 }
 
 }  // appcache namespace