Issue 9522009: Move tsan suppression for SequencedWorkerPool to benign section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9522009: Move tsan suppression for SequencedWorkerPool to benign section (Closed)

Created:
8 years, 9 months ago by akalin

Modified:
8 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move tsan suppression for SequencedWorkerPool to benign section Add unit test to consistently reproduce (benign) histogram race. BUG=115987 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124250

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -8 lines)			Patch
	M	base/threading/sequenced_worker_pool_unittest.cc	View		1 chunk	+27 lines, -0 lines	0 comments	Download
	M	tools/valgrind/tsan/suppressions.txt	View		2 chunks	+18 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

akalin

8 years, 9 months ago (2012-02-29 20:57:06 UTC) #3

On 2012/02/29 05:30:28, brettw wrote:
> lgtm

There are still reported races on the linux_tsan trybot, but they have to do
with the logging infrastructure (although the SWP tests trigger it
sporadically).

Checking this in, taking care of the logging races in another CL.

Expand Messages | Collapse Messages