Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: tools/valgrind/tsan/suppressions.txt

Issue 9522009: Move tsan suppression for SequencedWorkerPool to benign section (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/threading/sequenced_worker_pool_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # There are a few kinds of suppressions in this file. 1 # There are a few kinds of suppressions in this file.
2 # 1. third party stuff we have no control over 2 # 1. third party stuff we have no control over
3 # 3 #
4 # 2. intentional unit test errors, or stuff that is somehow a false positive 4 # 2. intentional unit test errors, or stuff that is somehow a false positive
5 # in our own code, or stuff that is so trivial it's not worth fixing 5 # in our own code, or stuff that is so trivial it's not worth fixing
6 # 6 #
7 # 3. Suppressions for real chromium bugs that are not yet fixed. 7 # 3. Suppressions for real chromium bugs that are not yet fixed.
8 # These should all be in chromium's bug tracking system (but a few aren't yet). 8 # These should all be in chromium's bug tracking system (but a few aren't yet).
9 # Periodically we should sweep this file and the bug tracker clean by 9 # Periodically we should sweep this file and the bug tracker clean by
10 # running overnight and removing outdated bugs/suppressions. 10 # running overnight and removing outdated bugs/suppressions.
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 fun:HistogramSynchronizer::DeserializeHistogramList* 395 fun:HistogramSynchronizer::DeserializeHistogramList*
396 } 396 }
397 397
398 { 398 {
399 bug_104776 Benign race to initialize pointer with the same value again. 399 bug_104776 Benign race to initialize pointer with the same value again.
400 ThreadSanitizer:Race 400 ThreadSanitizer:Race
401 fun:base::StatisticsRecorder::FindHistogram 401 fun:base::StatisticsRecorder::FindHistogram
402 fun:base::*Histogram::FactoryGet 402 fun:base::*Histogram::FactoryGet
403 } 403 }
404 404
405 {
406 bug_115987a [benign races in Histogram in SequencedWorkerPool]
407 ThreadSanitizer:Race
408 ...
409 fun:base::Histogram::*
410 fun:base::SequencedWorkerPool::*
411 }
412
413 # Histogram macros involve string comparison in debug mode.
414 {
415 bug_115987b [benign races in Histogram in SequencedWorkerPool]
416 ThreadSanitizer:Race
417 ...
418 fun:std::operator==
419 fun:base::SequencedWorkerPool::*
420 }
421
405 # 3. Suppressions for real chromium bugs that are not yet fixed. 422 # 3. Suppressions for real chromium bugs that are not yet fixed.
406 ############################ 423 ############################
407 # Real races in Chromium 424 # Real races in Chromium
408 { 425 {
409 bug_23433 426 bug_23433
410 ThreadSanitizer:Race 427 ThreadSanitizer:Race
411 fun:*logging*SetMinLogLevel* 428 fun:*logging*SetMinLogLevel*
412 } 429 }
413 430
414 { 431 {
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 } 868 }
852 { 869 {
853 bug_115540 870 bug_115540
854 ThreadSanitizer:Race 871 ThreadSanitizer:Race
855 fun:base::Thread::message_loop 872 fun:base::Thread::message_loop
856 fun:content::BrowserThreadImpl::PostTaskHelper 873 fun:content::BrowserThreadImpl::PostTaskHelper
857 fun:content::BrowserThread::PostTask 874 fun:content::BrowserThread::PostTask
858 fun:AudioRendererHost::OnCreated 875 fun:AudioRendererHost::OnCreated
859 fun:media::AudioOutputController::DoCreate 876 fun:media::AudioOutputController::DoCreate
860 } 877 }
861 { 878
862 bug_115987
863 ThreadSanitizer:Race
864 ...
865 fun:base::Histogram::Add
866 fun:base::SequencedWorkerPool::Inner::GetWork
867 fun:base::SequencedWorkerPool::Inner::ThreadLoop
868 }
OLDNEW
« no previous file with comments | « base/threading/sequenced_worker_pool_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698