Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 9517010: Change panels to be able to turn off autoresize. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc
index ada5e7e70c025cc2af57ead6f6e3e8a13d9d20a9..41b40f1e87c4d308bf85ebfc7ef590c9e713d47e 100644
--- a/chrome/browser/ui/panels/panel_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browsertest.cc
@@ -853,21 +853,17 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, ResizePanel) {
EXPECT_EQ(Panel::EXPANDED, panel->expansion_state());
// Verify resizing an auto-resizable panel is a no-op for now.
jennb 2012/02/28 23:45:15 update comment to say it also turns off auto-resiz
levin 2012/02/29 00:04:43 Done.
- // http://crbug.com/109343
gfx::Rect original_bounds = panel->GetBounds();
gfx::Rect original_restored_bounds = panel->GetRestoredBounds();
gfx::Size new_size(150, 200);
jennb 2012/02/28 23:45:15 Could do: gfx::Size new_size original_bounds.siz
levin 2012/02/29 00:04:43 Done.
- panel_manager->ResizePanel(panel, new_size);
- EXPECT_EQ(original_bounds, panel->GetBounds());
- EXPECT_EQ(original_restored_bounds, panel->GetRestoredBounds());
-
- // Verify resizing adjusts bounds correctly when not auto-resizable.
- panel->SetAutoResizable(false);
+ EXPECT_NE(new_size, original_bounds.size());
+ EXPECT_NE(new_size, original_restored_bounds.size());
panel_manager->ResizePanel(panel, new_size);
EXPECT_FALSE(panel->auto_resizable());
EXPECT_EQ(new_size, panel->GetBounds().size());
EXPECT_EQ(new_size, panel->GetRestoredBounds().size());
+
jennb 2012/02/28 23:45:15 extra blank line?
levin 2012/02/29 00:04:43 Done.
// Verify current height unaffected when panel is not expanded.
panel->SetExpansionState(Panel::MINIMIZED);
int original_height = panel->GetBounds().height();

Powered by Google App Engine
This is Rietveld 408576698