Change panels to be able to turn off autoresize.

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/net/url_request_mock_util.h"
@@ skipping 834 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, ResizePanel) {
   PanelManager* panel_manager = PanelManager::GetInstance();
   panel_manager->enable_auto_sizing(true);
 
   Panel* panel = CreatePanel("TestPanel");
   EXPECT_TRUE(panel->auto_resizable());
   EXPECT_EQ(Panel::EXPANDED, panel->expansion_state());
 
   // Verify resizing an auto-resizable panel is a no-op for now.

[jennb, 2012/02/28 23:45:15]

update comment to say it also turns off auto-resizability.

[levin, 2012/02/29 00:04:43]

Done.

-  // http://crbug.com/109343
   gfx::Rect original_bounds = panel->GetBounds();
   gfx::Rect original_restored_bounds = panel->GetRestoredBounds();
   gfx::Size new_size(150, 200);

[jennb, 2012/02/28 23:45:15]

Could do:

gfx::Size new_size  original_bounds.size();
new_size.width() + some_delta;  // create some different size
new_size.height() + some_delta;

Can delete the two EXPECT_NE lines below as we've explicitly made new_size
different from original_bounds.

[levin, 2012/02/29 00:04:43]

Done.

-  panel_manager->ResizePanel(panel, new_size);
-  EXPECT_EQ(original_bounds, panel->GetBounds());
-  EXPECT_EQ(original_restored_bounds, panel->GetRestoredBounds());
-
-  // Verify resizing adjusts bounds correctly when not auto-resizable.
-  panel->SetAutoResizable(false);
+  EXPECT_NE(new_size, original_bounds.size());
+  EXPECT_NE(new_size, original_restored_bounds.size());
   panel_manager->ResizePanel(panel, new_size);
   EXPECT_FALSE(panel->auto_resizable());
   EXPECT_EQ(new_size, panel->GetBounds().size());
   EXPECT_EQ(new_size, panel->GetRestoredBounds().size());
 
+

[jennb, 2012/02/28 23:45:15]

extra blank line?

[levin, 2012/02/29 00:04:43]

Done.

   // Verify current height unaffected when panel is not expanded.
   panel->SetExpansionState(Panel::MINIMIZED);
   int original_height = panel->GetBounds().height();
   new_size.Enlarge(5, 5);
   panel_manager->ResizePanel(panel, new_size);
   EXPECT_EQ(new_size.width(), panel->GetBounds().width());
   EXPECT_EQ(original_height, panel->GetBounds().height());
   EXPECT_EQ(new_size, panel->GetRestoredBounds().size());
 
   panel->Close();
@@ skipping 1116 matching lines @@
   // position when tall panel brings up its titlebar.
   CloseWindowAndWait(panel1->browser());
   EXPECT_EQ(balloon_bottom_after_tall_panel_titlebar_up,
             GetBalloonBottomPosition(balloon));
 
   // Closing the remaining tall panel should move the notification balloon back
   // to its original position.
   CloseWindowAndWait(panel2->browser());
   EXPECT_EQ(original_balloon_bottom, GetBalloonBottomPosition(balloon));
 }