Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 9490009: Thread isolate through Property constructor, avoiding Isolate::Current. (Closed)

Created:
8 years, 9 months ago by Sven Panne
Modified:
8 years, 9 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Thread isolate through Property constructor, avoiding Isolate::Current. This removes roughly 5k invocations of Isolate::Current from the string-tagcloud benchmark. Committed: https://code.google.com/p/v8/source/detail?r=10859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 9 months ago (2012-02-28 15:13:14 UTC) #1
fschneider
8 years, 9 months ago (2012-02-28 15:21:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698