Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/ast.cc

Issue 9490009: Thread isolate through Property constructor, avoiding Isolate::Current. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.h ('k') | src/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 int FunctionLiteral::end_position() const { 161 int FunctionLiteral::end_position() const {
162 return scope()->end_position(); 162 return scope()->end_position();
163 } 163 }
164 164
165 165
166 LanguageMode FunctionLiteral::language_mode() const { 166 LanguageMode FunctionLiteral::language_mode() const {
167 return scope()->language_mode(); 167 return scope()->language_mode();
168 } 168 }
169 169
170 170
171 ObjectLiteral::Property::Property(Literal* key, Expression* value) { 171 ObjectLiteral::Property::Property(Literal* key,
172 Expression* value,
173 Isolate* isolate) {
172 emit_store_ = true; 174 emit_store_ = true;
173 key_ = key; 175 key_ = key;
174 value_ = value; 176 value_ = value;
175 Object* k = *key->handle(); 177 Object* k = *key->handle();
176 if (k->IsSymbol() && HEAP->Proto_symbol()->Equals(String::cast(k))) { 178 if (k->IsSymbol() &&
179 isolate->heap()->Proto_symbol()->Equals(String::cast(k))) {
177 kind_ = PROTOTYPE; 180 kind_ = PROTOTYPE;
178 } else if (value_->AsMaterializedLiteral() != NULL) { 181 } else if (value_->AsMaterializedLiteral() != NULL) {
179 kind_ = MATERIALIZED_LITERAL; 182 kind_ = MATERIALIZED_LITERAL;
180 } else if (value_->AsLiteral() != NULL) { 183 } else if (value_->AsLiteral() != NULL) {
181 kind_ = CONSTANT; 184 kind_ = CONSTANT;
182 } else { 185 } else {
183 kind_ = COMPUTED; 186 kind_ = COMPUTED;
184 } 187 }
185 } 188 }
186 189
(...skipping 953 matching lines...) Expand 10 before | Expand all | Expand 10 after
1140 (node->name()->IsEqualTo(CStrVector("_ArgumentsLength")) || 1143 (node->name()->IsEqualTo(CStrVector("_ArgumentsLength")) ||
1141 node->name()->IsEqualTo(CStrVector("_Arguments")))) { 1144 node->name()->IsEqualTo(CStrVector("_Arguments")))) {
1142 // Don't inline the %_ArgumentsLength or %_Arguments because their 1145 // Don't inline the %_ArgumentsLength or %_Arguments because their
1143 // implementation will not work. There is no stack frame to get them 1146 // implementation will not work. There is no stack frame to get them
1144 // from. 1147 // from.
1145 add_flag(kDontInline); 1148 add_flag(kDontInline);
1146 } 1149 }
1147 } 1150 }
1148 1151
1149 } } // namespace v8::internal 1152 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698