Issue 9487012: Avoid mangling the name of native methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9487012: Avoid mangling the name of native methods. (Closed)

Created:
8 years, 9 months ago by kasperl

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid mangling the name of native methods. R=ngeoffray@google.com BUG=http://dartbug.com/1855 TEST= Committed: https://code.google.com/p/dart/source/detail?r=4742

Patch Set 2 : Rebase. #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -45 lines)			Patch
M	frog/analyze.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	frog/element.dart	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	frog/gen.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	frog/member.dart	View	7 chunks	+29 lines, -10 lines	0 comments	Download
M	frog/minfrog	View	14 chunks	+38 lines, -19 lines	0 comments	Download
A	frog/tests/native/src/NativeMethodWithKeywordNameTest.dart	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	frog/type.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	frog/world.dart	View	1 chunk	+1 line, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! http://codereview.chromium.org/9487012/diff/11/frog/world.dart File frog/world.dart (left): http://codereview.chromium.org/9487012/diff/11/frog/world.dart#oldcode341 frog/world.dart:341: 'split', Is this just for making this list ...

8 years, 9 months ago (2012-02-29 08:26:43 UTC) #2

kasperl

8 years, 9 months ago (2012-02-29 08:35:44 UTC) #3

Thanks for the review, Nicolas.

http://codereview.chromium.org/9487012/diff/11/frog/world.dart
File frog/world.dart (left):

http://codereview.chromium.org/9487012/diff/11/frog/world.dart#oldcode341
frog/world.dart:341: 'split',
On 2012/02/29 08:26:43, ngeoffray wrote:
> Is this just for making this list what it actually is: the JS reserved
keywords?
> And allowing to name things split except on members?

Yes. I just moved the hack and made it a bit more local.

Expand Messages | Collapse Messages

Issue 9487012: Avoid mangling the name of native methods. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase. #

Messages