Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: frog/world.dart

Issue 9487012: Avoid mangling the name of native methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/type.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/world.dart
diff --git a/frog/world.dart b/frog/world.dart
index 1717dfc9f4f315c3e9e60c6fc65c571a3215d7e6..67e7e191069c2c9ee73a9c77701e935e4209d314 100644
--- a/frog/world.dart
+++ b/frog/world.dart
@@ -333,13 +333,7 @@ class World {
'try', 'typeof', 'var', 'void', 'while', 'with',
'class', 'enum', 'export', 'extends', 'import', 'super',
'implements', 'interface', 'let', 'package', 'private',
- 'protected', 'public', 'static', 'yield',
- // Hack: we don't want Dart's String.split to overwrite the existing
- // JS String.split method. By adding 'split' to the keyword-set we
- // ensure that frog will not use the 'split' name but mangle it, thus
- // leaving the original JS String.split untouched.
- 'split',
ngeoffray 2012/02/29 08:26:43 Is this just for making this list what it actually
kasperl 2012/02/29 08:35:44 Yes. I just moved the hack and made it a bit more
- 'native']);
+ 'protected', 'public', 'static', 'yield', 'native']);
}
if (_jsKeywords.contains(name)) {
return name + '_';
« no previous file with comments | « frog/type.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698