Remove backends.

Remove backends.


R=zundel@google.com,brianwilkerson@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=4771

[Brian Wilkerson, 2012-02-27 20:47:02]

LGTM

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java
(right):

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java:109:
public static final String EXTENSION_JS = "js";
I believe that these two constants should eventually be removed. If so, please
mark them as @Deprecated and let me know whether you plan to clean them up or
want someone else to. Otherwise, please explain why we still need them.

[zundel, 2012-02-28 20:37:21]

http://codereview.chromium.org/9479013/diff/1/compiler/dart-compiler.gyp
File compiler/dart-compiler.gyp (right):

http://codereview.chromium.org/9479013/diff/1/compiler/dart-compiler.gyp#newc...
compiler/dart-compiler.gyp:42: '../third_party/rhino/1_7R3/js.jar',
I'm not sure if we still need this. I think I forgot it in my last CL.

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/CommandLineOptions.java (right):

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:48: @Option(name
= "--generate_source_maps",
this can go too

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:56: @Option(name
= "--human-readable-output",
this can go too

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:165: public
boolean generateSourceMaps() {
remove

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:169: public
boolean generateHumanReadableOutput() {
remove

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/CompilerConfiguration.java (right):

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/CompilerConfiguration.java:69: boolean
expectEntryPoint();
I think this is only referenced inside of packageApp, which you removed.

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/metrics/DartEventType.java (left):

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/metrics/DartEventType.java:25:
JS_NORMALIZE("DarkMagenta"),
You'd think this should now be removed.

http://codereview.chromium.org/9479013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/metrics/DartEventType.java:26:
JS_SOURCE_GEN("LightBlue"),
You'd think this should now be removed too.

http://codereview.chromium.org/9479013/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/DartBuilder.java
(right):

http://codereview.chromium.org/9479013/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/DartBuilder.java:46:
public static File getJsAppArtifactFile(IPath sourceLocation) {
Is this going to work with code generation removed?  Or will it just work with
the code generated by frog?

http://codereview.chromium.org/9479013/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/DartcBuildHandler.java
(right):

http://codereview.chromium.org/9479013/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/DartcBuildHandler.java:114:
if (extension.startsWith(DartCore.EXTENSION_APP_JS)) {
I don't think anyone should be creating files named <source>.app.js any more.

http://codereview.chromium.org/9479013/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java
(right):

http://codereview.chromium.org/9479013/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java:86:
if (extension.equals(DartCore.EXTENSION_APP_JS)) {
again, I'm not sure this test is useful anymore

[scheglov, 2012-02-29 22:46:40]

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/dart-compiler.gyp
File compiler/dart-compiler.gyp (right):

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/dart-compiler....
compiler/dart-compiler.gyp:42: '../third_party/rhino/1_7R3/js.jar',
On 2012/02/28 20:37:21, zundel wrote:
> I'm not sure if we still need this. I think I forgot it in my last CL.

Done.

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/CommandLineOptions.java (right):

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:48: @Option(name
= "--generate_source_maps",
On 2012/02/28 20:37:21, zundel wrote:
> this can go too

Done.

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:56: @Option(name
= "--human-readable-output",
On 2012/02/28 20:37:21, zundel wrote:
> this can go too

Done.

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:165: public
boolean generateSourceMaps() {
On 2012/02/28 20:37:21, zundel wrote:
> remove

Done.

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:169: public
boolean generateHumanReadableOutput() {
On 2012/02/28 20:37:21, zundel wrote:
> remove

Done.

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/CompilerConfiguration.java (right):

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/CompilerConfiguration.java:69: boolean
expectEntryPoint();
On 2012/02/28 20:37:21, zundel wrote:
> I think this is only referenced inside of packageApp, which you removed.

Done.

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/metrics/DartEventType.java (left):

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/metrics/DartEventType.java:25:
JS_NORMALIZE("DarkMagenta"),
On 2012/02/28 20:37:21, zundel wrote:
> You'd think this should now be removed.

Done.

https://chromiumcodereview.appspot.com/9479013/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/metrics/DartEventType.java:26:
JS_SOURCE_GEN("LightBlue"),
On 2012/02/28 20:37:21, zundel wrote:
> You'd think this should now be removed too.

Done.

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java
(right):

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java:109:
public static final String EXTENSION_JS = "js";
On 2012/02/27 20:47:03, Brian Wilkerson wrote:
> I believe that these two constants should eventually be removed. If so, please
> mark them as @Deprecated and let me know whether you plan to clean them up or
> want someone else to. Otherwise, please explain why we still need them.

I've added @Deprecated for EXTENSION_JS.

EXTENSION_APP_JS is not used and was removed.

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/DartBuilder.java
(right):

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/DartBuilder.java:46:
public static File getJsAppArtifactFile(IPath sourceLocation) {
On 2012/02/28 20:37:21, zundel wrote:
> Is this going to work with code generation removed?  Or will it just work with
> the code generated by frog?

Yes, this still may be needed by frog.

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/DartcBuildHandler.java
(right):

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/DartcBuildHandler.java:114:
if (extension.startsWith(DartCore.EXTENSION_APP_JS)) {
On 2012/02/28 20:37:21, zundel wrote:
> I don't think anyone should be creating files named <source>.app.js any more.

Done.

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java
(right):

https://chromiumcodereview.appspot.com/9479013/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/compiler/DartCompilerWarmup.java:86:
if (extension.equals(DartCore.EXTENSION_APP_JS)) {
On 2012/02/28 20:37:21, zundel wrote:
> again, I'm not sure this test is useful anymore

Done.

[zundel, 2012-02-29 22:51:59]

LGTM other than developerModeChecks issue

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/CommandLineOptions.java (left):

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:237: public
boolean developerModeChecks() {
it turns out we might need this.  There is at least one place in the spec where
something is a warning in production mode and a compile-time error in developer
mode.

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1121: if
(!isValueAssignable) {
developer mode checks are important here, because this error is a compile-time
error.

[scheglov, 2012-02-29 23:14:55]

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/CommandLineOptions.java (left):

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:237: public
boolean developerModeChecks() {
On 2012/02/29 22:51:59, zundel wrote:
> it turns out we might need this.  There is at least one place in the spec
where
> something is a warning in production mode and a compile-time error in
developer
> mode.

Hm...
I don't see this.

Logically this is type problem, so it should be static type warning at analysis
and dynamic type error in checked mode at runtime.

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1121: if
(!isValueAssignable) {
On 2012/02/29 22:51:59, zundel wrote:
> developer mode checks are important here, because this error is a compile-time
> error.

Should I just change this to be an type warning?

[zundel, 2012-02-29 23:24:51]

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/CommandLineOptions.java (left):

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:237: public
boolean developerModeChecks() {
On 2012/02/29 23:14:55, scheglov wrote:
> On 2012/02/29 22:51:59, zundel wrote:
> > it turns out we might need this.  There is at least one place in the spec
> where
> > something is a warning in production mode and a compile-time error in
> developer
> > mode.
> 
> Hm...
> I don't see this.
> 
> Logically this is type problem, so it should be static type warning at
analysis
> and dynamic type error in checked mode at runtime.

I dug up my old notes.  Basically, near the bottom of section 10.1 it says that
"it is a compile-time error if evaluation of a compile-time constant would raise
an exception. "  Well, if you violate the assignability in this case, and you
turn on developer mode, a TypeError would be thrown, and therefore, the sentence
kicks in and you'd have a compile-time error.

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1121: if
(!isValueAssignable) {
On 2012/02/29 23:14:55, scheglov wrote:
> On 2012/02/29 22:51:59, zundel wrote:
> > developer mode checks are important here, because this error is a
compile-time
> > error.
> 
> Should I just change this to be an type warning?

No, it is a compile-time error if developer mode is enabled.  If developer mode
is not enabled, a warning comes out of the 'checkAssignable()' code.

[scheglov, 2012-02-29 23:46:59]

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/9479013/diff/12001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1121: if
(!isValueAssignable) {
On 2012/02/29 23:24:51, zundel wrote:
> On 2012/02/29 23:14:55, scheglov wrote:
> > On 2012/02/29 22:51:59, zundel wrote:
> > > developer mode checks are important here, because this error is a
> compile-time
> > > error.
> > 
> > Should I just change this to be an type warning?
> 
> No, it is a compile-time error if developer mode is enabled.  If developer
mode
> is not enabled, a warning comes out of the 'checkAssignable()' code.

OK, restored.