Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: compiler/java/com/google/dart/compiler/metrics/CompilerMetrics.java

Issue 9479013: Remove backends. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: More clean up Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/metrics/CompilerMetrics.java
diff --git a/compiler/java/com/google/dart/compiler/metrics/CompilerMetrics.java b/compiler/java/com/google/dart/compiler/metrics/CompilerMetrics.java
index 161cbccc7cd256fb25ef444a6ebb26df9167f076..3f7d9380f6c6b32e2538b37364d13ddfb0d086ee 100644
--- a/compiler/java/com/google/dart/compiler/metrics/CompilerMetrics.java
+++ b/compiler/java/com/google/dart/compiler/metrics/CompilerMetrics.java
@@ -46,10 +46,6 @@ public final class CompilerMetrics {
private long nanoParseWallTime = 0;
private AtomicLong nanoTotalParseTime = new AtomicLong();
private long nativeLibCharCount;
- private long packageAppTime = 0L;
- private long packageAppTimeStart = 0L;
- // JavascriptBackend Data
- private long totalJsOutputCharCount;
// Parser metrics
private AtomicLong unitsParsed = new AtomicLong();
@@ -85,10 +81,6 @@ public final class CompilerMetrics {
compileLibrariesTime = System.currentTimeMillis() - compileLibrariesTimeStart;
}
- public void endPackageAppTime() {
- packageAppTime = System.currentTimeMillis() - packageAppTimeStart;
- }
-
public void endUpdateAndResolveTime() {
updateAndResolveTime = System.currentTimeMillis() - updateAndResolveTimeStart;
}
@@ -101,10 +93,6 @@ public final class CompilerMetrics {
return nativeLibCharCount;
}
- public long getJSOutputCharSize() {
- return totalJsOutputCharCount;
- }
-
public double getLinesPerMS() {
return getNumLinesParsed() / getTotalCompilationTime();
}
@@ -133,10 +121,6 @@ public final class CompilerMetrics {
return unitsParsed.get();
}
- public long getPackageAppTime() {
- return packageAppTime;
- }
-
public double getParseTime() {
return nanoToMillis(nanoTotalParseTime.get());
}
@@ -152,20 +136,6 @@ public final class CompilerMetrics {
public double getPercentTimeParsing() {
return getParseTime() / getTotalCompilationTime();
}
-
- public double getRatioOutputToInput() {
- if (getNumCharsParsed() == 0) {
- return 0;
- }
- return getJSOutputCharSize() / getNumCharsParsed();
- }
-
- public double getRatioOutputToInputExcludingComments() {
- if (getNumNonCommentChars() == 0) {
- return 0;
- }
- return getJSOutputCharSize() / getNumNonCommentChars();
- }
public double getTimeSpentPerUnit() {
if (getNumUnitsParsed() == 0) {
@@ -182,26 +152,10 @@ public final class CompilerMetrics {
return updateAndResolveTime;
}
- /**
- * Records that the application was packaged to JS.
- *
- * @param totalJsOutputCharSize number of characts of JS output produced
- * @param nativeLibCharCount number of characters of JS output consumed by native JS libs or -1 if
- * the backend did not record this information
- */
- public void packagedJsApplication(long totalJsOutputCharSize, long nativeLibCharCount) {
- this.totalJsOutputCharCount = totalJsOutputCharSize;
- this.nativeLibCharCount = nativeLibCharCount;
- }
-
public void startCompileLibrariesTime() {
compileLibrariesTimeStart = System.currentTimeMillis();
}
- public void startPackageAppTime() {
- packageAppTimeStart = System.currentTimeMillis();
- }
-
public void startUpdateAndResolveTime() {
updateAndResolveTimeStart = System.currentTimeMillis();
}
@@ -226,7 +180,6 @@ public final class CompilerMetrics {
out.format("Compile-time-total-ms : %1$.2f%n", getTotalCompilationTime());
out.format("# Update-and-resolve-time-ms : %d\n", getUpdateAndResolveTime());
out.format("# Compile-libraries-time-ms : %d\n", getCompileLibrariesTime());
- out.format("# Package-app-time-ms : %d\n", getPackageAppTime());
out.println("# Compile-time-unit-average-ms : " + getTimeSpentPerUnit());
out.format("# Parse-wall-time-ms : %1$.2f%n", getParseWallTime());
out.format("# Parse-time-ms : %1$.2f%n", getParseTime());
@@ -235,13 +188,10 @@ public final class CompilerMetrics {
out.println("# Parsed-src-lines : " + getNumLinesParsed());
out.println("# Parsed-code-chars : " + getNumNonCommentChars());
out.println("# Parsed-code-lines : " + getNumNonCommentLines());
- out.println("# Output-js-chars : " + getJSOutputCharSize());
double jsNativeLibCharSize = (getJSNativeLibCharSize() == -1) ? 0 : getJSNativeLibCharSize();
out.println("# Output-js-native-lib-chars : " + jsNativeLibCharSize );
out.println("# Processed-total-lines-ms : " + getLinesPerMS());
out.println("# Processed-code-lines-ms : " + getNonCommentLinesPerMS());
- out.println("# Ratio-output-intput-total : " + getRatioOutputToInput());
- out.println("# Ratio-output-intput-code : " + getRatioOutputToInputExcludingComments());
out.println("# Ratio-parsing-compile-percent : " + getPercentTimeParsing() * 100);
}
}

Powered by Google App Engine
This is Rietveld 408576698