Issue 9466048: Implement (subset of) ISO 8601 for date-reading. Fix other bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9466048: Implement (subset of) ISO 8601 for date-reading. Fix other bugs. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement (subset of) ISO 8601 for date-reading. Fix other bugs. Date.fromString now tries to read in an ISO 8601 first. If that fails it falls back to the JS implementation. Fix some typos in frog's date implementation. Fixes issue 1763. Fixes issue 1472. Committed: https://code.google.com/p/dart/source/detail?r=4630

Patch Set 1 #

Patch Set 2 : Fix bad millisecond parsing. #

Patch Set 3 : Add assert. #

Total comments: 2

Patch Set 4 : Add comment. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -20 lines)			Patch
M	frog/leg/lib/mockimpl.dart	View	1 2 3	1 chunk	+34 lines, -4 lines	0 comments	Download
M	frog/lib/date_implementation.dart	View	1 2 3	2 chunks	+70 lines, -15 lines	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/corelib/src/DateTimeTest.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

I have a follow-up patch that will add some examples next to the regexp and ...

8 years, 9 months ago (2012-02-27 14:15:35 UTC) #1

ngeoffray

LGTM https://chromiumcodereview.appspot.com/9466048/diff/5001/frog/leg/lib/mockimpl.dart File frog/leg/lib/mockimpl.dart (right): https://chromiumcodereview.appspot.com/9466048/diff/5001/frog/leg/lib/mockimpl.dart#newcode240 frog/leg/lib/mockimpl.dart:240: // back to JavaScript's implementation. Please explain why ...

8 years, 9 months ago (2012-02-27 17:05:41 UTC) #3

floitsch

8 years, 9 months ago (2012-02-27 18:05:27 UTC) #4

https://chromiumcodereview.appspot.com/9466048/diff/5001/frog/leg/lib/mockimp...
File frog/leg/lib/mockimpl.dart (right):

https://chromiumcodereview.appspot.com/9466048/diff/5001/frog/leg/lib/mockimp...
frog/leg/lib/mockimpl.dart:240: // back to JavaScript's implementation.
On 2012/02/27 17:05:41, ngeoffray wrote:
> Please explain why you're doing this.

Done.

Expand Messages | Collapse Messages