Implement (subset of) ISO 8601 for date-reading. Fix other bugs.

frog/leg/lib/mockimpl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Mocks of classes and interfaces that Leg cannot read directly.
 
 // TODO(ahe): Remove this file.
 
 class JSSyntaxRegExp implements RegExp {
   final String pattern;
@@ skipping 217 matching lines @@
                                                    timeZone.isUtc) {
     _asJs();
   }
 
   DateImplementation.now()
       : timeZone = new TimeZone.local(),
         value = Primitives.dateNow() {
     _asJs();
   }
 
-  DateImplementation.fromString(String formattedString)
-      : timeZone = new TimeZone.local(),
-        value = Primitives.valueFromDateString(formattedString) {
-    _asJs();
+  factory DateImplementation.fromString(String formattedString) {
+    // Always try to read in (a subset of) ISO 8601 first. If that fails fall
+    // back to JavaScript's implementation.

[ngeoffray, 2012/02/27 17:05:41]

Please explain why you're doing this.

[floitsch, 2012/02/27 18:05:27]

Done.

+    final RegExp re =
+        const RegExp(@'^([+-]?\d?\d\d\d\d)-?(\d\d)-?(\d\d) (\d\d):(\d\d):(\d\d)(?:.(\d{1,3}))? ?([zZ]?)$');
+    Match match = re.firstMatch(formattedString);
+    if (match !== null) {
+      int years = Math.parseInt(match[1]);
+      int month = Math.parseInt(match[2]);
+      int day = Math.parseInt(match[3]);
+      int hours = Math.parseInt(match[4]);
+      int minutes = Math.parseInt(match[5]);
+      int seconds = Math.parseInt(match[6]);
+      int milliseconds = 0;
+      if (match[7] !== null) {
+        milliseconds = Math.parseInt(match[7]);
+        if (match[7].length == 1) {
+          milliseconds *= 100;
+        } else if (match[7].length == 2) {
+          milliseconds *= 10;
+        } else {
+          assert(match[7].length == 3);
+        }
+      }
+      bool isUtc = match[8] !== null;
+      TimeZone timezone = isUtc ? const TimeZone.utc() : new TimeZone.local();
+      return new DateImplementation.withTimeZone(
+          years, month, day, hours, minutes, seconds, milliseconds, timezone);
+    } else {
+      return new DateImplementation.fromEpoch(formattedString,
+                                              new TimeZone.local());
+    }
   }
 
   const DateImplementation.fromEpoch(this.value, this.timeZone);
 
   bool operator ==(other) {
     if (!(other is DateImplementation)) return false;
     return (value == other.value) && (timeZone == other.timeZone);
   }
 
   int compareTo(Date other) {
@@ skipping 138 matching lines @@
     }
     String twoDigitMinutes =
         twoDigits(inMinutes.remainder(Duration.MINUTES_PER_HOUR));
     String twoDigitSeconds =
         twoDigits(inSeconds.remainder(Duration.SECONDS_PER_MINUTE));
     String threeDigitMs =
         threeDigits(inMilliseconds.remainder(Duration.MILLISECONDS_PER_SECOND));
     return "${inHours}:${twoDigitMinutes}:${twoDigitSeconds}.${threeDigitMs}";
   }
 }