Chromium Code Reviews| Index: tools/testing/dart/test_suite.dart |
| =================================================================== |
| --- tools/testing/dart/test_suite.dart (revision 4566) |
| +++ tools/testing/dart/test_suite.dart (working copy) |
| @@ -177,9 +177,11 @@ |
| bool isNegative; |
| bool isNegativeIfChecked; |
| bool hasFatalTypeErrors; |
| + bool hasRuntimeErrors; |
| TestInformation(this.filename, this.optionsFromFile, this.isNegative, |
| - this.isNegativeIfChecked, this.hasFatalTypeErrors); |
| + this.isNegativeIfChecked, this.hasFatalTypeErrors, |
| + this.hasRuntimeErrors); |
| } |
| @@ -296,6 +298,9 @@ |
| int middle = filename.lastIndexOf('_'); |
| testName = filename.substring(start + 1, middle) + '/' + |
| filename.substring(middle + 1, filename.length - 5); |
| + if ((configuration['component'] == 'dartc') && info.hasRuntimeErrors) { |
| + isNegative = false; |
| + } |
|
Bill Hesse
2012/02/24 13:58:36
I think this could be moved to line 345, since run
ngeoffray
2012/02/24 14:08:10
Done.
|
| } else { |
| // This case is hit by the dartc client compilation |
| // tests. These tests are pretty broken compared to the |
| @@ -362,13 +367,15 @@ |
| return (String filename, |
| bool isNegative, |
| [bool isNegativeIfChecked = false, |
| - bool hasFatalTypeErrors = false]) { |
| + bool hasFatalTypeErrors = false, |
| + bool hasRuntimeErrors = false]) { |
| // Cache the test information for each test case. |
| var info = new TestInformation(filename, |
| optionsFromFile, |
| isNegative, |
| isNegativeIfChecked, |
| - hasFatalTypeErrors); |
| + hasFatalTypeErrors, |
| + hasRuntimeErrors); |
| cachedTests.add(info); |
| enqueueTestCaseFromTestInformation(info); |
| }; |