Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: tools/testing/dart/multitest.dart

Issue 9466008: Use the component information when the test is being scheduled instead of when it's being created. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | tools/testing/dart/test_suite.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/multitest.dart
===================================================================
--- tools/testing/dart/multitest.dart (revision 4566)
+++ tools/testing/dart/multitest.dart (working copy)
@@ -123,7 +123,8 @@
Function doTest(String filename,
bool isNegative,
[bool isNegativeIfChecked,
- bool hasFatalTypeErrors]),
+ bool hasFatalTypeErrors,
+ bool hasRuntimeErrors]),
Function multitestDone) {
// Each new test is a single String value in the Map tests.
Map<String, String> tests = new Map<String, String>();
@@ -146,13 +147,15 @@
openedFile.closeSync();
var outcome = outcomes[key];
bool enableFatalTypeErrors = outcome.contains('static type error');
- bool isNegative = (outcome.contains('compile-time error')
- || (outcome.contains('runtime error') && (component != 'dartc')));
+ bool hasRuntimeErrors = outcome.contains('runtime error');
+ bool isNegative = hasRuntimeErrors
+ || outcome.contains('compile-time error');
bool isNegativeIfChecked = outcome.contains('dynamic type error');
doTest(filename,
isNegative,
isNegativeIfChecked,
- enableFatalTypeErrors);
+ enableFatalTypeErrors,
+ hasRuntimeErrors);
}
multitestDone();
}
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | tools/testing/dart/test_suite.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698