Issue 9455016: Fix bug in r10812.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9455016: Fix bug in r10812. (Closed)

Created:
8 years, 10 months ago by Yang

Modified:
8 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bug in r10812. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10816

Patch Set 3 : add NULL check #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	src/hydrogen-instructions.cc	View	1 2	1 chunk	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

https://chromiumcodereview.appspot.com/9455016/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/9455016/diff/1/src/hydrogen-instructions.cc#newcode388 src/hydrogen-instructions.cc:388: // dead and only the first item in the ...

8 years, 10 months ago (2012-02-23 15:33:38 UTC) #2

LGTM.

Expand Messages | Collapse Messages

Issue 9455016: Fix bug in r10812. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : add NULL check #

Messages