Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: src/hydrogen-instructions.cc

Issue 9455016: Fix bug in r10812. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: add NULL check Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index 9d39d033eb7a9d0cf56c8a24b6b6ef0dbf73f235..3b0b367da8674fc6442984e0fe01001bb7e98aae 100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -384,9 +384,18 @@ void HValue::DeleteAndReplaceWith(HValue* other) {
if (other != NULL) ReplaceAllUsesWith(other);
ASSERT(HasNoUses());
// Clearing the operands includes going through the use list of each operand
- // to remove this HValue, which can be expensive. Instead, we simply mark it
- // as dead and remove it lazily from the operands' use lists.
+ // to remove this HValue, which can be expensive. Instead, we mark this as
+ // dead and only check the first item in the use list of each operand.
+ // For the following items in the use lists we rely on the tail() method to
+ // skip dead dead items and remove them lazily.
SetFlag(kIsDead);
+ for (int i = 0; i < OperandCount(); ++i) {
+ HValue* operand = OperandAt(i);
+ HUseListNode* first = operand->use_list_;
+ if (first != NULL && first->index() == i && first->value() == this) {
+ operand->use_list_ = first->tail();
+ }
+ }
DeleteFromGraph();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698