Issue 9452022: Speed up removing phi nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9452022: Speed up removing phi nodes. (Closed)

Created:
8 years, 10 months ago by Yang

Modified:
8 years, 10 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Speed up removing phi nodes. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10817

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -17 lines)			Patch
M	src/hydrogen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View	2 chunks	+11 lines, -15 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

It turned out that my original CL that replaces ClearOperands in GVN had a bug, ...

8 years, 10 months ago (2012-02-23 17:23:53 UTC) #1

fschneider

8 years, 10 months ago (2012-02-24 08:42:03 UTC) #2

lgtm

http://codereview.chromium.org/9452022/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

http://codereview.chromium.org/9452022/diff/1/src/hydrogen-instructions.cc#ne...
src/hydrogen-instructions.cc:412: if (first != NULL && first->index() == i &&
first->value() == this) {
Maybe reorder the condition to:

if (first != NULL && first->value() == this && first->index() == i)

Expand Messages | Collapse Messages