src/hydrogen.cc - Issue 9452022: Speed up removing phi nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 9452022: Speed up removing phi nodes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 9918e8518096044441006ae7a39ec0fe137b169d..6bc8af595d2eb26ac0fb069351560dbf8faad410 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -97,7 +97,7 @@ void HBasicBlock::RemovePhi(HPhi* phi) {

ASSERT(phi->block() == this);

ASSERT(phis_.Contains(phi));

ASSERT(phi->HasNoUses() || !phi->is_live());

- phi->ClearOperands();

+ phi->Kill();

phis_.RemoveElement(phi);

phi->SetBlock(NULL);

}

« no previous file with comments | « no previous file | src/hydrogen-instructions.h » ('j') | src/hydrogen-instructions.cc » ('J')