Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2248)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/input.py

Issue 9451001: Don't allow empty string as first argument of action. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/rules-dirname/src/subdir/input-rule-dirname.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/input.py
===================================================================
--- pylib/gyp/input.py (revision 1232)
+++ pylib/gyp/input.py (working copy)
@@ -2152,6 +2152,11 @@
"An action must have an 'action_name' field." %
target_name)
inputs = action.get('inputs', [])
+ action_command = action.get('action')
+ if action_command:
(unused - use chromium) 2012/02/23 01:55:19 if action_command and not action-command[0]: rai
+ if action_command[0] == '':
+ raise Exception("Empty action as command in target %s. " %
+ target_name)
def ValidateRunAsInTarget(target, target_dict, build_file):
« no previous file with comments | « no previous file | test/rules-dirname/src/subdir/input-rule-dirname.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698