Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 9451001: Don't allow empty string as first argument of action. (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 10 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Don't allow empty string as first argument of action. For some reason, there was an extra empty argument at the beginning of these cygwin rules. It looks like it was originally in rules and copy-pasted to rules-dirname, so I assume just a typo in the first place. This Exception was not raised when I ran "python build/gyp_chromium" on the Chromium code base. Committed: https://code.google.com/p/gyp/source/detail?r=1233

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pylib/gyp/input.py View 1 2 3 4 5 6 2 chunks +4 lines, -1 line 0 comments Download
M test/rules-dirname/src/subdir/input-rule-dirname.gyp View 1 chunk +1 line, -1 line 0 comments Download
M test/rules/src/external/external.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
8 years, 10 months ago (2012-02-23 01:46:56 UTC) #1
(unused - use chromium)
8 years, 10 months ago (2012-02-23 01:55:19 UTC) #2
LGTM

Please land a gyp roll soon after landing.

https://chromiumcodereview.appspot.com/9451001/diff/1/pylib/gyp/input.py
File pylib/gyp/input.py (right):

https://chromiumcodereview.appspot.com/9451001/diff/1/pylib/gyp/input.py#newc...
pylib/gyp/input.py:2156: if action_command:
if action_command and not action-command[0]:
  raise...

Powered by Google App Engine
This is Rietveld 408576698