net/http/http_response_headers_unittest.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_headers_unittest.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_response_headers_unittest.cc

diff --git a/net/http/http_response_headers_unittest.cc b/net/http/http_response_headers_unittest.cc

index 775946cf0a08ca6f5a9d361db628cb8fac0f8651..90ff48fcbeab1160a055a8a89c7f87c5f3f4282b 100644

--- a/net/http/http_response_headers_unittest.cc

+++ b/net/http/http_response_headers_unittest.cc

@@ -475,7 +475,7 @@ TEST(HttpResponseHeadersTest, Persist) {

Pickle pickle;

parsed1->Persist(&pickle, tests[i].options);

- void* iter = NULL;

+ PickleReader iter(pickle);

scoped_refptr<net::HttpResponseHeaders> parsed2(

new net::HttpResponseHeaders(pickle, &iter));