net/http/http_response_headers.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_headers.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_response_headers.cc

diff --git a/net/http/http_response_headers.cc b/net/http/http_response_headers.cc

index 491649844204ab41f7cfe4f78fb897a65d20fc79..c178fe26b7ece0331015affe057f3f59eed85d18 100644

--- a/net/http/http_response_headers.cc

+++ b/net/http/http_response_headers.cc

@@ -169,7 +169,8 @@ HttpResponseHeaders::HttpResponseHeaders(const std::string& raw_input)

GetAllHttpResponseCodes());

}

-HttpResponseHeaders::HttpResponseHeaders(const Pickle& pickle, void** iter)

+HttpResponseHeaders::HttpResponseHeaders(const Pickle& pickle,

+ PickleReader* iter)

: response_code_(-1) {

std::string raw_input;

if (pickle.ReadString(iter, &raw_input))