Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: net/base/x509_certificate.h

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jar feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/x509_certificate.h
diff --git a/net/base/x509_certificate.h b/net/base/x509_certificate.h
index 0a603b1ad9219d8adcb7cf7b10ae3f6ebdcab7f0..5c8168bcbd187090598a7a2b613b89832f740a50 100644
--- a/net/base/x509_certificate.h
+++ b/net/base/x509_certificate.h
@@ -37,6 +37,7 @@ struct CERTCertificateStr;
#endif
class Pickle;
+class PickleReader;
namespace crypto {
class RSAPrivateKey;
@@ -181,7 +182,7 @@ class NET_EXPORT X509Certificate
//
// The returned pointer must be stored in a scoped_refptr<X509Certificate>.
static X509Certificate* CreateFromPickle(const Pickle& pickle,
- void** pickle_iter,
+ PickleReader* pickle_iter,
PickleType type);
// Parses all of the certificates possible from |data|. |format| is a
@@ -554,7 +555,7 @@ class NET_EXPORT X509Certificate
// libraries, nor acceptable to CreateFromBytes(). Returns an invalid
// handle, NULL, on failure.
static OSCertHandle ReadOSCertHandleFromPickle(const Pickle& pickle,
- void** pickle_iter);
+ PickleReader* pickle_iter);
// Writes a single certificate to |pickle|. Returns false on failure.
static bool WriteOSCertHandleToPickle(OSCertHandle handle, Pickle* pickle);

Powered by Google App Engine
This is Rietveld 408576698