net/base/x509_certificate.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_certificate.cc

diff --git a/net/base/x509_certificate.cc b/net/base/x509_certificate.cc

index 0a301e0e147e1ef62a0152435e6a2cac4c7ec3d6..128b8385e1d5b966228ce88f10a97874472213fe 100644

--- a/net/base/x509_certificate.cc

+++ b/net/base/x509_certificate.cc

@@ -324,7 +324,7 @@ X509Certificate* X509Certificate::CreateFromBytes(const char* data,

// static

X509Certificate* X509Certificate::CreateFromPickle(const Pickle& pickle,

- void** pickle_iter,

+ PickleReader* pickle_iter,

PickleType type) {

OSCertHandle cert_handle = ReadOSCertHandleFromPickle(pickle, pickle_iter);

if (!cert_handle)