ipc/ipc_message.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_message.cc

diff --git a/ipc/ipc_message.cc b/ipc/ipc_message.cc

index 703588d001403d3d384efa4f97f025925a6bd851..92c813b32ba9510700d8c9a20568f8b2ce50bea1 100644

--- a/ipc/ipc_message.cc

+++ b/ipc/ipc_message.cc

@@ -100,7 +100,7 @@ bool Message::WriteFileDescriptor(const base::FileDescriptor& descriptor) {

}

-bool Message::ReadFileDescriptor(void** iter,

+bool Message::ReadFileDescriptor(PickleReader* iter,

base::FileDescriptor* descriptor) const {

int descriptor_index;

if (!ReadInt(iter, &descriptor_index))