ipc/ipc_message.h - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message.h

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_message.h

diff --git a/ipc/ipc_message.h b/ipc/ipc_message.h

index b6304324d1467c8af2cc6509cb60b97332d1f684..4ffa6c6f1b56f9137d64981dea7c4ebc95c771af 100644

--- a/ipc/ipc_message.h

+++ b/ipc/ipc_message.h

@@ -180,7 +180,8 @@ class IPC_EXPORT Message : public Pickle {

bool WriteFileDescriptor(const base::FileDescriptor& descriptor);

// Get a file descriptor from the message. Returns false on error.

// iter: a Pickle iterator to the current location in the message.

- bool ReadFileDescriptor(void** iter, base::FileDescriptor* descriptor) const;

+ bool ReadFileDescriptor(PickleReader* iter,

+ base::FileDescriptor* descriptor) const;

#endif

#ifdef IPC_MESSAGE_LOG_ENABLED