content/common/ssl_status_serialization.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/ssl_status_serialization.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/ssl_status_serialization.cc

diff --git a/content/common/ssl_status_serialization.cc b/content/common/ssl_status_serialization.cc

index fdd64069d307bbac71754e4875ed067ebdf268b8..169158b5368c5dfb5307a5e1a88a2343f5bf814a 100644

--- a/content/common/ssl_status_serialization.cc

+++ b/content/common/ssl_status_serialization.cc

@@ -38,7 +38,7 @@ bool DeserializeSecurityInfo(const std::string& state,

}

Pickle pickle(state.data(), static_cast<int>(state.size()));

- void * iter = NULL;

+ PickleReader iter(pickle);

return pickle.ReadInt(&iter, cert_id) &&

pickle.ReadUInt32(&iter, cert_status) &&

pickle.ReadInt(&iter, security_bits) &&