content/ppapi_plugin/ppapi_thread.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/ppapi_plugin/ppapi_thread.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/ppapi_plugin/ppapi_thread.cc

diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc

index 8ef6d6b3b587619aed312c5f9b44bdb4d86ceb8d..d423be0c4ec9690e99dbcb0ffd6151b95f432cc2 100644

--- a/content/ppapi_plugin/ppapi_thread.cc

+++ b/content/ppapi_plugin/ppapi_thread.cc

@@ -256,7 +256,7 @@ void PpapiThread::OnMsgSetNetworkState(bool online) {

void PpapiThread::OnPluginDispatcherMessageReceived(const IPC::Message& msg) {

// The first parameter should be a plugin dispatcher ID.

- void* iter = NULL;

+ PickleReader iter(msg);

uint32 id = 0;

if (!msg.ReadUInt32(&iter, &id)) {

NOTREACHED();