content/browser/download/base_file.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/base_file.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/base_file.cc

diff --git a/content/browser/download/base_file.cc b/content/browser/download/base_file.cc

index f7d045d29863b2a7b79345172fcf170fb346e55d..7696ee1c2116651dd0607f05f06269d68d0de9d0 100644

--- a/content/browser/download/base_file.cc

+++ b/content/browser/download/base_file.cc

@@ -455,9 +455,9 @@ bool BaseFile::SetHashState(const std::string& hash_state_bytes) {

return false;

Pickle hash_state(hash_state_bytes.c_str(), hash_state_bytes.size());

- void* data_iterator = NULL;

+ PickleReader data_iterator(hash_state);

- return secure_hash_->Deserialize(&data_iterator, &hash_state);

+ return secure_hash_->Deserialize(&data_iterator);

}

bool BaseFile::IsEmptyHash(const std::string& hash) {