Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: content/browser/download/base_file.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jar feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/base_file.cc
diff --git a/content/browser/download/base_file.cc b/content/browser/download/base_file.cc
index f7d045d29863b2a7b79345172fcf170fb346e55d..7696ee1c2116651dd0607f05f06269d68d0de9d0 100644
--- a/content/browser/download/base_file.cc
+++ b/content/browser/download/base_file.cc
@@ -455,9 +455,9 @@ bool BaseFile::SetHashState(const std::string& hash_state_bytes) {
return false;
Pickle hash_state(hash_state_bytes.c_str(), hash_state_bytes.size());
- void* data_iterator = NULL;
+ PickleReader data_iterator(hash_state);
- return secure_hash_->Deserialize(&data_iterator, &hash_state);
+ return secure_hash_->Deserialize(&data_iterator);
}
bool BaseFile::IsEmptyHash(const std::string& hash) {

Powered by Google App Engine
This is Rietveld 408576698