Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4336)

Unified Diff: chrome/test/automation/automation_proxy.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jar feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/automation_proxy.cc
diff --git a/chrome/test/automation/automation_proxy.cc b/chrome/test/automation/automation_proxy.cc
index fdfc5eb9aa2e29501fc11c071a158d612f7d6997..0760051118afb32ab188e18b3d433fdf0f2adb1e 100644
--- a/chrome/test/automation/automation_proxy.cc
+++ b/chrome/test/automation/automation_proxy.cc
@@ -79,7 +79,7 @@ class AutomationMessageFilter : public IPC::ChannelProxy::MessageFilter {
void OnAutomationHello(const IPC::Message& hello_message) {
std::string server_version;
- void* iter = NULL;
+ PickleReader iter(hello_message);
if (!hello_message.ReadString(&iter, &server_version)) {
// We got an AutomationMsg_Hello from an old automation provider
// that doesn't send version info. Leave server_version as an empty
@@ -462,7 +462,7 @@ bool AutomationProxy::Send(IPC::Message* message, int timeout_ms) {
}
void AutomationProxy::InvalidateHandle(const IPC::Message& message) {
- void* iter = NULL;
+ PickleReader iter(message);
int handle;
if (message.ReadInt(&iter, &handle)) {

Powered by Google App Engine
This is Rietveld 408576698