chrome/renderer/extensions/user_script_slave.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/user_script_slave.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/user_script_slave.cc

diff --git a/chrome/renderer/extensions/user_script_slave.cc b/chrome/renderer/extensions/user_script_slave.cc

index c0641975fd56e4381b11809e125b828a0cb52ceb..49dc4ddf082a26dce462abdf03e4baa5aae02d89 100644

--- a/chrome/renderer/extensions/user_script_slave.cc

+++ b/chrome/renderer/extensions/user_script_slave.cc

@@ -155,10 +155,10 @@ bool UserScriptSlave::UpdateScripts(base::SharedMemoryHandle shared_memory) {

return false;

// Unpickle scripts.

- void* iter = NULL;

size_t num_scripts = 0;

Pickle pickle(reinterpret_cast<char*>(shared_memory_->memory()),

pickle_size);

+ PickleReader iter(pickle);

pickle.ReadSize(&iter, &num_scripts);

scripts_.reserve(num_scripts);