chrome/common/automation_messages.h - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/automation_messages.h

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/automation_messages.h

diff --git a/chrome/common/automation_messages.h b/chrome/common/automation_messages.h

index 3d5598ec2d53eda921d72ef9fe618d8e793ca82a..3783c44c0171b528f2dc7661d14e099f077b8364 100644

--- a/chrome/common/automation_messages.h

+++ b/chrome/common/automation_messages.h

@@ -192,7 +192,7 @@ template <>

struct ParamTraits<ContextMenuModel> {

typedef ContextMenuModel param_type;

static void Write(Message* m, const param_type& p);

- static bool Read(const Message* m, void** iter, param_type* p);

+ static bool Read(const Message* m, PickleReader* iter, param_type* p);

static void Log(const param_type& p, std::string* l);

};