chrome/common/automation_messages.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/automation_messages.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/automation_messages.cc

diff --git a/chrome/common/automation_messages.cc b/chrome/common/automation_messages.cc

index 1801fd68c8327f3a4245287117419d7905cd60f9..243c4f7b4415c1e0f5102a3331607b49f07c7365 100644

--- a/chrome/common/automation_messages.cc

+++ b/chrome/common/automation_messages.cc

@@ -73,7 +73,7 @@ void ParamTraits<ContextMenuModel>::Write(Message* m,

// static

bool ParamTraits<ContextMenuModel>::Read(const Message* m,

- void** iter,

+ PickleReader* iter,

param_type* p) {

size_t item_count = 0;

if (!ReadParam(m, iter, &item_count))