chrome/browser/extensions/extension_browser_actions_api.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browser_actions_api.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_browser_actions_api.cc

diff --git a/chrome/browser/extensions/extension_browser_actions_api.cc b/chrome/browser/extensions/extension_browser_actions_api.cc

index 0a37658901cf686c8ac45d251e5843be7e8aca0c..8e77bc09bbb890d008ced20748e8045afd8bdefa 100644

--- a/chrome/browser/extensions/extension_browser_actions_api.cc

+++ b/chrome/browser/extensions/extension_browser_actions_api.cc

@@ -49,7 +49,7 @@ bool BrowserActionSetIconFunction::RunBrowserAction() {

base::BinaryValue* binary = NULL;

EXTENSION_FUNCTION_VALIDATE(details_->GetBinary("imageData", &binary));

IPC::Message bitmap_pickle(binary->GetBuffer(), binary->GetSize());

- void* iter = NULL;

+ PickleReader iter(bitmap_pickle);

SkBitmap bitmap;

EXTENSION_FUNCTION_VALIDATE(

IPC::ReadParam(&bitmap_pickle, &iter, &bitmap));