chrome/browser/extensions/extension_messages_browsertest.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_messages_browsertest.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_messages_browsertest.cc

diff --git a/chrome/browser/extensions/extension_messages_browsertest.cc b/chrome/browser/extensions/extension_messages_browsertest.cc

index 6f9feb35540817d53362a34fc53aee1577f27423..129839530244baac7274cf00f70fb056f7a7d74c 100644

--- a/chrome/browser/extensions/extension_messages_browsertest.cc

+++ b/chrome/browser/extensions/extension_messages_browsertest.cc

@@ -65,7 +65,7 @@ TEST_F(ChromeRenderViewTest, ExtensionMessagesOpenChannel) {

render_thread_->sink().GetUniqueMessageMatching(

ExtensionHostMsg_OpenChannelToExtension::ID);

ASSERT_TRUE(open_channel_msg);

- void* iter = IPC::SyncMessage::GetDataIterator(open_channel_msg);

+ PickleReader iter = IPC::SyncMessage::GetDataIterator(open_channel_msg);

ExtensionHostMsg_OpenChannelToExtension::SendParam open_params;

ASSERT_TRUE(IPC::ReadParam(open_channel_msg, &iter, &open_params));

EXPECT_EQ("testName", open_params.d);