Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: ui/base/clipboard/clipboard_unittest.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jar feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/clipboard/clipboard_unittest.cc
diff --git a/ui/base/clipboard/clipboard_unittest.cc b/ui/base/clipboard/clipboard_unittest.cc
index 84056b994fa99f93fcca3d37eaee0d6da1dbc359..140f8f95b474423b35ef019b74edb9d62dbefa3f 100644
--- a/ui/base/clipboard/clipboard_unittest.cc
+++ b/ui/base/clipboard/clipboard_unittest.cc
@@ -449,7 +449,7 @@ TEST_F(ClipboardTest, DataTest) {
ASSERT_FALSE(output.empty());
Pickle read_pickle(output.data(), output.size());
- void* iter = NULL;
+ PickleReader iter(read_pickle);
std::string unpickled_string;
ASSERT_TRUE(read_pickle.ReadString(&iter, &unpickled_string));
EXPECT_EQ(payload, unpickled_string);
@@ -486,7 +486,7 @@ TEST_F(ClipboardTest, MultipleDataTest) {
ASSERT_FALSE(output2.empty());
Pickle read_pickle2(output2.data(), output2.size());
- void* iter2 = NULL;
+ PickleReader iter2(read_pickle2);
std::string unpickled_string2;
ASSERT_TRUE(read_pickle2.ReadString(&iter2, &unpickled_string2));
EXPECT_EQ(payload2, unpickled_string2);
@@ -508,7 +508,7 @@ TEST_F(ClipboardTest, MultipleDataTest) {
ASSERT_FALSE(output1.empty());
Pickle read_pickle1(output1.data(), output1.size());
- void* iter1 = NULL;
+ PickleReader iter1(read_pickle1);
std::string unpickled_string1;
ASSERT_TRUE(read_pickle1.ReadString(&iter1, &unpickled_string1));
EXPECT_EQ(payload1, unpickled_string1);

Powered by Google App Engine
This is Rietveld 408576698