ppapi/proxy/serialized_var.cc - Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/serialized_var.cc

Issue 9447084: Refactor Pickle Read methods to use higher performance PickleIterator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jar feedback Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/serialized_var.cc

diff --git a/ppapi/proxy/serialized_var.cc b/ppapi/proxy/serialized_var.cc

index eb2033318d6097d30d3bb403d078ea5670981d41..952f4155d769ebb4bae0e74f035f26760eff88e8 100644

--- a/ppapi/proxy/serialized_var.cc

+++ b/ppapi/proxy/serialized_var.cc

@@ -147,7 +147,7 @@ void SerializedVar::Inner::WriteToMessage(IPC::Message* m) const {

}

-bool SerializedVar::Inner::ReadFromMessage(const IPC::Message* m, void** iter) {

+bool SerializedVar::Inner::ReadFromMessage(const IPC::Message* m, PickleReader* iter) {

#ifndef NDEBUG

// We should only deserialize something once or will end up with leaked

// references.